backend/.gitignore (1)

8-14: Consolidate environment-related entries with existing section.

The added entries venv/ (line 11) and .env/ (line 12) duplicate or overlap with existing ignore patterns at lines 111–117. While this doesn't break functionality, consolidating them would reduce maintenance burden and improve clarity.

Consider removing lines 11–12 and adding .sync-env/ to the existing environment section (around line 117), or if .env/ is intentionally distinct from .env, clarify the difference.

Proposed fix: Move .sync-env/ to the environment section and remove duplicates.

-
-
-.sync-env/
-venv/
-.env/
-

Then add to the environment section (after line 117):

 venv.bak/
+.sync-env/

frontend/src/components/GalleryView.tsx (1)

180-180: Add fallback UI for unknown view modes.

Returning null silently when the mode doesn't match any known value provides no feedback. Consider rendering a fallback message or defaulting to chronological mode.

Apply this diff to provide better user feedback:

-  return null;
+  // Fallback to chronological if mode is somehow invalid
+  console.warn(`Unknown view mode: ${mode}, falling back to chronological`);
+  return (
+    <ChronologicalGallery
+      images={images}
+      showTitle={true}
+      title={title}
+      onMonthOffsetsChange={onMonthOffsetsChange}
+      scrollContainerRef={scrollableRef}
+    />
+  );

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

frontend/src/pages/Home/Home.tsx (1)

66-71: Remove the type cast on images (duplicate concern).

The images as any type cast on line 67 bypasses type safety. As noted in the previous review, the AnyImage type in GalleryView is permissive enough to accept the Image type without this cast.

Apply this diff to remove the unnecessary type cast:

-          <GalleryView
-            images={images as any}
+          <GalleryView
+            images={images}
             title={title}
             scrollableRef={scrollableRef}
             onMonthOffsetsChange={setMonthMarkers}
           />

frontend/src/pages/Home/Home.tsx (1)

59-59: Consider conditionally rendering the ViewModeToggle.

The ViewModeToggle is currently visible even when the gallery is empty. For better UX, consider only showing it when images are available.

Apply this diff to conditionally render the toggle:

-      <ViewModeToggle />
+      {images.length > 0 && <ViewModeToggle />}

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

frontend/src/components/GalleryView.tsx (1)

86-97: Remove unnecessary type cast.

The images as any cast at line 90 bypasses TypeScript's type checking. Since AnyImage is already designed to be permissive and extends Partial<MediaImage>, this cast should be unnecessary.

Apply this diff:

       <ChronologicalGallery
-        images={images as any} // ChronologicalGallery expects your original Image type
+        images={images}
         showTitle={true}
         title={title}
         onMonthOffsetsChange={onMonthOffsetsChange}
         scrollContainerRef={scrollableRef}
       />

frontend/src/components/GalleryView.tsx (3)

120-120: Remove unnecessary type cast for alt text.

The type cast as string is unnecessary because the expression (img.name || img.filename || String(img.id)) already guarantees a string result through the String() fallback.

Apply this diff:

-              alt={(img.name || img.filename || String(img.id)) as string}
+              alt={img.name || img.filename || String(img.id)}

Also applies to lines 156, 206.

---

185-185: Minor: Inconsistent spacing before comment.

Extra whitespace before the comment at line 185 is inconsistent with the rest of the file (compare with lines 99, 134).

Apply this diff:

-
- // MASONRY
+  // MASONRY

---

111-116: Consider extracting the keyboard handler to reduce duplication.

The onKeyDown handler is duplicated across grid, list, and masonry modes. Extracting it into a reusable function would improve maintainability.

For example, add this helper near handleImageClick:

  const handleKeyDown = useCallback(
    (index: number, e: React.KeyboardEvent) => {
      if (e.key === 'Enter' || e.key === ' ') {
        e.preventDefault();
        handleImageClick(index);
      }
    },
    [handleImageClick],
  );

Then use it in each mode:

-            onKeyDown={(e) => {
-              if (e.key === 'Enter' || e.key === ' ') {
-                e.preventDefault();
-                handleImageClick(index);
-              }
-            }}
+            onKeyDown={(e) => handleKeyDown(index, e)}

Also applies to lines 146-151, 196-201.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

frontend/src/components/GalleryView.tsx (2)

155-167: Remove images as any when passing to ChronologicalGallery.

Casting images to any disables type checking between AnyImage and the image type expected by ChronologicalGallery. Given AnyImage is already designed to be compatible with your existing image shape, it’s better to keep type safety and adjust types if they don’t line up.

If ChronologicalGallery expects MediaImage[], you can either:

• Update its props to accept the more general AnyImage[], or
• Narrow images earlier (e.g., ensure they’re MediaImage[]) and pass them without any:

-      <ChronologicalGallery
-        images={images as any} // ChronologicalGallery expects your original Image type
+      <ChronologicalGallery
+        images={images}
         showTitle={true}
         title={title}
         onMonthOffsetsChange={onMonthOffsetsChange}
         scrollContainerRef={scrollableRef}
       />

This keeps the compiler helping you instead of hiding potential mismatches.

---

203-205: Restore MediaView’s onClose handler and avoid repeated unsafe casts.

For grid, list, and masonry modes you currently render:

{isImageViewOpen && <MediaView images={images as MediaImage[]} />}

Issues:

1. Missing onClose handler – Previous reviews noted MediaView expects an onClose prop so users can exit the viewer. Without it, the viewer may be non‑dismissable, which is a critical UX bug.
2. Repeated images as MediaImage[] casts – These bypass type checking and assume every AnyImage meets MediaImage’s requirements. If they diverge, you’ll only find out at runtime.
3. Duplicate logic – The same MediaView snippet is repeated in three branches and can easily get out of sync.

Consider:

-        {isImageViewOpen && <MediaView images={images as MediaImage[]} />}
+        {isImageViewOpen && (
+          <MediaView
+            images={images as MediaImage[]}
+            onClose={() => dispatch(setCurrentViewIndex(-1))}
+          />
+        )}

and applying the same change in the list and masonry branches. Longer‑term, you could extract a small helper (e.g., renderMediaView()) to avoid copy‑pasting this block and to centralize any future prop changes.

Also applies to: 255-257, 303-304

frontend/src/components/ViewModeToggle.tsx (1)

23-55: Consider adding explicit accessible labels (or visible text) to the toggle buttons.

Right now each button is icon‑only and relies on title={m.label} as its label. Title is not a reliable accessible name across assistive tech and is invisible on touch devices. Consider either:

• Adding aria-label={m.label} to the <button>, and/or
• Rendering a visually hidden <span className="sr-only">{m.label}</span> inside the button (or even visible text on larger screens).

This keeps the UI clean while making the control more discoverable and screen‑reader friendly.

frontend/src/components/GalleryView.tsx (2)

35-40: Tighten Props typing: avoid any union and redundant | null in RefObject.

• onMonthOffsetsChange: (v: MonthMarker[] | any) => void; effectively collapses to any. If ChronologicalGallery really emits MonthMarker[], prefer a precise type like (v: MonthMarker[]) => void (or MonthMarker[] | undefined if needed).
• scrollableRef: React.RefObject<HTMLDivElement | null>; is redundant because RefObject<T> already exposes current: T | null. Use React.RefObject<HTMLDivElement> instead for clearer typing.

These tweaks keep the API self‑documenting and preserve TypeScript’s checking.

---

89-96: Avoid skipping valid ids when toggling favourites.

handleToggleFavourite uses if (img?.id), which will skip ids like 0 or an empty string even though they’re valid identifiers elsewhere (you already use String(img.id) for React keys).

Prefer a null/undefined check instead, for example:

-  if (img?.id) {
-    toggleFavourite(String(img.id));
-  }
+  if (img && img.id != null) {
+    toggleFavourite(String(img.id));
+  }

This ensures all legitimate ids participate in favourites.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro